[68561] UI broken when user with whom a wp has been shared opens the project #20879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDinger
requested changes
Nov 3, 2025
| ) do |t| | ||
| t.with_icon(icon: :"op-view-list") | ||
| t.with_text { I18n.t("overviews.label_dashboard") } | ||
| if current_user.allowed_in_project?(:view_members, project) |
There was a problem hiding this comment.
I don't know what was discussed as the linked meeting does not really reveal that. However, just looking at the code, it makes no sense to hide the whole dashboard when a user does not have the permission to view members. We don't even know, whether the members widget is shown in the dashboard. Maybe I am missing something here, but this looks wrong.
There was a problem hiding this comment.
It is the meeting link: https://community.openproject.org/meetings/7224#meeting-agenda-item-20127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/68561
What are you trying to accomplish?
As discussed in https://community.openproject.org/projects/design-system/work_packages/68657/meetings, Don't show the dashboard, when the user doesn't have the permission to manage dashboard.